Fix #78 Add new option toggle_list
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toggled property is a setting that does not retain the On state. Set
this if your AC properties are toggle function.
toggle_list: #optional - default []
- Beep
- Clean
- Econo
- Filter
- Light
- Quiet
- Sleep
- SwingH
- SwingV
- Turbo
|
@nao-pon How does this toggle list work? What is it for? |
|
This is a fix for the toggle command reported in #78. Toggle commands switch On/Off by sending On. If this integration remembers the On state, it will always send On when sending other commands, which is not the correct behavior. This PR does not save the On value for the specified command and only sends the On value by service call. However, since I don't have the corresponding device, I can't verify the operation, and I'm still waiting for a reply at #78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toggled property is a setting that does not retain the On state. Set this if your AC properties are toggle function.
toggle_list: #optional - default []
- Beep
- Clean
- Econo
- Filter
- Light
- Quiet
- Sleep
- SwingH
- SwingV
- Turbo